Skip to content
This repository was archived by the owner on Mar 14, 2020. It is now read-only.

Grab back keyboard focus after layout view get the focus#268

Merged
grgustaf merged 3 commits into
intel:masterfrom
zhizhangchen:focus2
Aug 30, 2012
Merged

Grab back keyboard focus after layout view get the focus#268
grgustaf merged 3 commits into
intel:masterfrom
zhizhangchen:focus2

Conversation

@zhizhangchen

Copy link
Copy Markdown
Contributor

No description provided.

@grgustaf grgustaf merged commit 2f1af9a into intel:master Aug 30, 2012
@grgustaf

Copy link
Copy Markdown
Contributor

Merged. It would be preferable if clicking the checkbox could set keyboard focus without showing the gray rectangle. That's what a normal web page does. I'm not sure how you'd make that happen. So you don't see a rectangle, but if you press Tab you'll see that the keyboard focus was in fact there.

Also, there seems to be a bug where most of the time when you click a checkbox you see the keyboard focus flicker and appear twice. I assume this is because of duplicate focus requests happening. Minor, but should fix at some point.

Still, this is good progress so I'll merge it.

@grgustaf

Copy link
Copy Markdown
Contributor

Max submitted a separate fix for the checkbox problem and his doesn't seem to have the double-focus issue, I think because he uses the "focusElement" to update focus after the fact, rather than setting it immediately. So I think that issue is now resolved.

@grgustaf

Copy link
Copy Markdown
Contributor

Er but now if I unclick an already clicked checkbox that is not selected, sometimes I get a triple flash of the gray rectangle. So let's not count that one as fixed quite yet. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants