[Widget]: Add dialog support in RIB#37
Conversation
There was a problem hiding this comment.
Better reword this:
Forbid changing the style of the first page to "Dialog"
|
When testing, there's a problem: Uncaught SyntaxError: Duplicate data property in object literal not allowed in strict mode. |
|
How to reproduce this result? Thanks
|
|
The code has been rebased and basic test are done. |
|
The code has be rebased according to latest change. |
|
Pleas rebase this pull request as it has conflicts with the master |
* because the first page of RIB must be a page, we don't show the checkbox of dialog for the first page in property view
according to style, creating page as dialog or page
In design view, we make dialog and page looked as same.
* There are different behavior on button opening target between JQM and RIB. For JQM, when data-role of page is "dialog" and the page is loaded by a button with the data-rel=page, the behavior of the page is "Page". Fixing this bug by modifying default value of opentargetas property of button.
|
update it. |
|
I went ahead and took most of this although I don't like adding more hard-coded logic about widgets in our views. That is something that will need to be a separate project to clean up. I did not take the ddfde09 patch, see my comment. You can close this. |
3 participants
Add dialog support in RIB