This repository was archived by the owner on Mar 14, 2020. It is now read-only.
Bug fix for property and widgets#86
Closed
xuzhang wants to merge 2 commits into
Closed
Conversation
Closed
Contributor
|
As there are many conflicts, please rebase the branch with master. Note that we have introduced new extension mechanism in widgets.js, so we need to be cautious when defining Base widget's field: it will be inherited by extending widget if it doesn't override it. |
Contributor
There was a problem hiding this comment.
"showInProperty" might be a better name than "isShownInProperty", which mean's it has already be shown in property. showInProperty means it should be shown in property
Closed
Contributor
|
Please rebase this PR as it can't be merged automatically now. In fact b004cff can be removed from this PR now as other commit has fixed this problem |
Add a check in function refresh(): in case property of some widget such as design is shown in property view.
only update view when widget can be shown in outline. Orignally, we ignore property of design changes. When property of design node changes, outline view doesn't need update
Contributor
Author
|
rebased code and please review PR. |
Contributor
|
Replaced by #135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Widgets] Bug Fix: getPropertySchema() should retern a clone of object
[Property View] only widgets in palette panel can be shown
[Outline View] enforce check in _modelUpdatedHandler