This repository was archived by the owner on Mar 14, 2020. It is now read-only.
[FileIO] Add upload APIs in $.rib.fsUtils namespace#91
Merged
Conversation
Contributor
Author
|
Sub-commit can be picked up earlier in #87, "features about theme" assigned to Xu is based on this pull request. |
Contributor
|
I'm confused... these functions look like they should be in fs.js, not serialize.js. |
Contributor
Author
|
Yes, it looks like APIs related with fs, but the upload API will trigger a native dialog, and used basic APIs in fs.js, so I think they are higher than basic APIs in fs.js, and related with UI, interact with users. So, they may be separated with basic APIs of file system. |
Contributor
|
Another option is to put these functions in an upload.js file |
Contributor
There was a problem hiding this comment.
Should we also describe savePath here?
Contributor
Author
|
updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.