fix(docker): убрать image: line — compose не пытается pull несуществующий образ#5
Merged
Merged
Conversation
Текущий compose имел и `build:` и `image: fold-runtime-quickstart:local`. Docker compose сначала пытался pull этот image из registry (его там нет, т.к. публикуем только локально), фейлился ~3.1s с `pull access denied for fold-runtime-quickstart, repository does not exist or may require 'docker login'`, и только потом fall back'ал на build из cache. В Loom-демо это первое что видит зритель — красная ошибка перед banner'ом. Plot read'ится как «что-то сломано». Fix: убрать `image:` line. Compose сразу build'ит из Dockerfile (или подтягивает уже cache'нутый layer'ы — instant). Никаких pull-попыток. Container name остаётся `fold-host` (был под `image:`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
В Loom-демо первое что видел зритель в первые 3 секунды — красный pull-error:
```
! Image fold-runtime-quickstart:local pull access denied for
fold-runtime-quickstart, repository does not exist or may require
'docker login' 3.1s
[+] Building 0.2s (1/2)
```
Это потому что compose имел и `build:` и `image: fold-runtime-quickstart:local`. По default'у compose сначала пытается pull, фейлится (мы локальный образ, в registry его нет), потом fall back на build.
Fix
Убрать `image:` line. Build выполнится сразу. Никаких pull-попыток в логах.
Test