feat: add support for locales=* Contentful responses#24
Merged
Conversation
…cript-codegen into feat/localization-flag
Contributor
Author
|
@stevenpetryk btw, can you please explain the importance of this line? From what I understand, if a key is present in the json fetched from contentful api, it will not be |
8bbedc1 to
542b456
Compare
542b456 to
9d76a9b
Compare
stevenpetryk
approved these changes
Apr 16, 2020
stevenpetryk
left a comment
Contributor
There was a problem hiding this comment.
Nicely done. Thanks a bunch for the contribution.
Contributor
I'll admit, this is based on some odd typings in Intercom's marketing site codebase 😆I don't know if it's still necessary. |
Contributor
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20
Overview
Add a new
--localizationflag. When enabled, generated fields will wrapped inLocalizedFieldhelper , for example:This flag is very useful when entries are being fetched with
locale="*".Notes
field.requiredis ignored, because contentful api ignores it as well.AssetThis change is