Skip to content

feat: add dex-general and dex-stable rpc defs#103

Open
gregdhill wants to merge 1 commit into
masterfrom
feat/dex-rpc
Open

feat: add dex-general and dex-stable rpc defs#103
gregdhill wants to merge 1 commit into
masterfrom
feat/dex-rpc

Conversation

@gregdhill
Copy link
Copy Markdown
Member

Signed-off-by: Gregory Hill gregorydhill@outlook.com

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Comment thread definitions.json
"params": [
{
"name": "supply",
"type": "AssetBalance"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this crash serde?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested and I think not, although I'm not sure if I'm missing something or if this was indeed fixed in serde

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw many of the rpcs using FixedU128 would have the same issue

Copy link
Copy Markdown
Member

@sander2 sander2 Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw many of the rpcs using FixedU128 would have the same issue

That's not true, FixedU128 has a customSerialize implementation that serializes as string (similarly to our balance wrapper)

Copy link
Copy Markdown
Member

@sander2 sander2 Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if you tested then I guess they must have fixed it upstream. Edit: it seems you just need the arbitrary_precision feature. We don't explicitly enable it but maybe one of our dependencies does serde-rs/json#548 . Edit 2: cargo tree -e features does not show the arbitrary_precision feature being enabled..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants