Skip to content

Sync with iris for all local repo changes - #373

Merged
isc-tleavitt merged 16 commits into
mainfrom
sync-iris-codebase-change
Jun 25, 2024
Merged

Sync with iris for all local repo changes#373
isc-tleavitt merged 16 commits into
mainfrom
sync-iris-codebase-change

Conversation

@isc-hwojnick

@isc-hwojnick isc-hwojnick commented Jun 24, 2024

Copy link
Copy Markdown
Contributor

Anytime a git command occurs that adds or deletes files, IRIS will sync with the changes to the project

Fixes #153

Comment thread cls/SourceControl/Git/Utils.cls Outdated
Comment thread cls/SourceControl/Git/Utils.cls Outdated
Comment thread cls/SourceControl/Git/Utils.cls Outdated
@isc-hwojnick isc-hwojnick changed the title Fixes Issue #153 Sync iris codebase change Fixes #153 Sync iris codebase change Jun 24, 2024
@isc-hwojnick
isc-hwojnick requested a review from isc-pbarton June 24, 2024 14:05

@isc-pbarton isc-pbarton left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also test using the "Git Pull" page in the UI to pull changes please (that is, the page you get to if you follow the "Git Pull" link in the Favorites in the SMP). I'm seeing unexpected behavior with that page but I'm not sure yet if it's related to this change.

Comment thread cls/SourceControl/Git/Utils.cls Outdated
Comment thread cls/SourceControl/Git/Utils.cls Outdated
@isc-hwojnick
isc-hwojnick requested a review from isc-pbarton June 24, 2024 16:31
@isc-tleavitt
isc-tleavitt self-requested a review June 24, 2024 16:56
@isc-tleavitt isc-tleavitt changed the title Fixes #153 Sync iris codebase change Sync with iris for all local repo changes Jun 24, 2024
Comment thread cls/SourceControl/Git/Utils.cls
@isc-hwojnick
isc-hwojnick requested a review from isc-pbarton June 25, 2024 13:46

@isc-tleavitt isc-tleavitt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SourceControl.Git.API:Pull is part of the API for git-source-control. We shouldn't/can't just remove it.

Comment thread cls/SourceControl/Git/API.cls
Comment thread cls/SourceControl/Git/Utils.cls Outdated
@isc-hwojnick
isc-hwojnick requested a review from isc-pbarton June 25, 2024 16:39
Comment thread cls/_zpkg/isc/sc/git/Socket.cls Outdated
@isc-hwojnick
isc-hwojnick requested a review from isc-pbarton June 25, 2024 17:47
Comment thread cls/_zpkg/isc/sc/git/Socket.cls Outdated
@isc-tleavitt
isc-tleavitt merged commit 44dd368 into main Jun 25, 2024
@isc-tleavitt
isc-tleavitt deleted the sync-iris-codebase-change branch June 25, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync code with IRIS after all codebase changes

3 participants