Add Media Queries support, and re-introduce the one-whole width.#3
Add Media Queries support, and re-introduce the one-whole width.#3emagnier wants to merge 6 commits into
Conversation
|
yeah, one-whole is very important for me, too. |
There was a problem hiding this comment.
Suggestion : The variables related to media-query output should be renamed to follow the naming conventions found in other "igloos".
$inuit-enable-widths--responsive: false !default;
$inuit-enable-widths--responsive-extra: false !default;There was a problem hiding this comment.
Thanks for your suggestion. I made a new commit following your recommendation.
|
Why is necessary? Isn't this why the layout element has width: 100% set by default? https://github.com/inuitcss/objects.layout/blob/master/_objects.layout.scss - you would just fallback to this, if no namespaced value is present for a certain viewport |
|
This is a great start but I'm afraid the natural language output looks a bit odd. Examples below:
Basically, the pluralisation is a bit inconsistent. |
|
@jameshoward you are right, I did not paid attention to the pluralisation... (English is not my native language). I will send a new commit very soon to fix that. Thanks for the report! |
|
I made a new commit to fix the pluralizing inconsistencies. |
|
Thanks for your work on this, and sorry for ignoring it. I think that—seeing as we already have the widths typed out—we don’t stand to gain that much from generating them automatically. In fact, I feel it adds a layer of obscurity in that you have to be able to decipher the Sass. I have started working on a Many thanks, |
|
No problem for that. As you suggested here #2 I will package my work in an inuitcss plugin. I also took a look at the Thanks, |
|
As I said in an other thread, I have created a new plugin, and made another one for the responsive widths.
|
Media Queries support:
media-querymixin from Inuit v5 as a reference.mapdata-type), and the mixin adds a comment block before each group of proportions.media-querymixin is not available (detected via the newmixin-existsfunction), it will warn the user.one-whole/1-wholewidth:_trumps.widthin my latest project, and the1-wholewas still necessary, particularly for some specific breakpoints.If I have some time soon, I will play a bit with the pull & push helpers. I will submit a Gist for that (because this will be probably a new independent module).