Add Support for rocm57 required by some AMD GPU#7531
Closed
cbayle wants to merge 8 commits into
Closed
Conversation
cbayle
requested review from
blessedcoolant,
ebr,
hipsterusername and
lstein
as code owners
|
anything holding this back? |
en0
reviewed
May 23, 2025
en0
left a comment
en0
left a comment
There was a problem hiding this comment.
I was trying similar fixes locally and noticed you had a couple typeos in this mr
| if [ -c /dev/dri/card0 ] | ||
| then | ||
| VIDEO_GID=$(stat -c %g /dev/dri/card0) | ||
| _=$(getent group ${VIDEO_GID} 2>&1) || groupadd ${VIDEO_GID} video |
There was a problem hiding this comment.
this should be groupadd -g ${VIDEO_GID} video
| then | ||
| VIDEO_GID=$(stat -c %g /dev/dri/card0) | ||
| _=$(getent group ${VIDEO_GID} 2>&1) || groupadd ${VIDEO_GID} video | ||
| usermod -a -G $VIDEO_GID $USER |
There was a problem hiding this comment.
although this will likely work as is, it is more correct to do usermod -aG video $USER
Collaborator
|
Superseded by #8867 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for rocm57 required by some AMD GPU, For example my RX 7600 XT
fix /dev/kfd and /dev/dri/card0 ownership when required
fix a small issue of extra \n in docker/run.sh
Related Issues / Discussions
may fix bug #4211 when using docker/run.sh
Merge Plan
I took care not to provoke regression by adding a new rocm57 profile
Checklist
-[x] The PR has a short but descriptive title, suitable for a changelog
-[x] _Documentation added / updated in .env.sample