feat(android-template): allow HTTP for debug builds#2224
Conversation
This means livereload from localhost will work with no additional configuration.
jcesarmobile
left a comment
There was a problem hiding this comment.
Thanks but I think we shouldn't enable it by default for debug builds, this will lead to different behaviour in debug and release configs and people not knowing why their connections fail only in release as already happen in Cordova and causes a lot of frustration.
It would be better if we had a new property in the server object of capacitor.config.json that the CLI could read and write this code into the capacitor-cordova-android-plugins module based on it (since it's autogenerated and overwritten by the CLI). Then document that property and also make Ionic CLI write it when using live reload command.
|
Added it only for Since a nice out of the box |
|
I've sent a PR with what I proposed, WDYT? #2395 this way, Ionic CLI should have to add this to the |
This means livereload from localhost will work with no additional
configuration.