Skip to content

Fix to allow angular base url#101

Merged
jcesarmobile merged 8 commits into
ionic-team:wip-serverfrom
jcesarmobile:baseurl-fix
Jun 11, 2018
Merged

Fix to allow angular base url#101
jcesarmobile merged 8 commits into
ionic-team:wip-serverfrom
jcesarmobile:baseurl-fix

Conversation

@jcesarmobile
Copy link
Copy Markdown
Member

As we do on Capacitor, just serve the www folder so angular's base url works

@imhoffd
Copy link
Copy Markdown
Contributor

imhoffd commented Jun 2, 2018

@jcesarmobile This appears to redirect everything to index.html, is that correct? If so, can we have an html5mode option like in Android?

@jcesarmobile
Copy link
Copy Markdown
Member Author

It shouldn't redirect everything to index.html. Did you faced that problem?

I've just updated to use startPage instead of index.html. That's for when the user loads "/" instead of a file.
Also when the url user tries to load is file:///blah/blah/blah/startPage, it will redirect to localhost:port/startPage, but just that one, the rest should redirect to localhost:port/otherfile

@jcesarmobile jcesarmobile changed the base branch from master to wip-android June 11, 2018 15:31
@jcesarmobile jcesarmobile changed the base branch from wip-android to master June 11, 2018 15:31
@jcesarmobile jcesarmobile changed the base branch from master to wip-server June 11, 2018 15:42
@jcesarmobile jcesarmobile merged commit 2be9da2 into ionic-team:wip-server Jun 11, 2018
@jcesarmobile jcesarmobile deleted the baseurl-fix branch June 11, 2018 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants