Skip to content

fix(#3965): give --lab access to serve externalAddress #4650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ghustavh97 wants to merge 2 commits into from
Closed

fix(#3965): give --lab access to serve externalAddress #4650

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25b6f05
fix(#3965): give --lab access to serve externalAddress
Ghustavh97 Feb 24, 2021
f77fa4c
Merge branch 'develop' into dynamic-host
Ghustavh97 May 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@ionic/cli/src/lib/serve.ts
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ class IonicLabServeCLI extends ServeCLI<IonicLabServeCLIOptions> {

const pkg = await this.e.project.requirePackageJson();

const url = `${serveDetails.protocol}://localhost:${serveDetails.port}`;
const url = `${serveDetails.protocol}://${serveDetails.externalAddress}:${serveDetails.port}`;
const appName = this.e.project.config.get('name');
const labArgs = [url, '--host', labDetails.host, '--port', String(labDetails.port), '--project-type', labDetails.projectType];
const nameArgs = appName ? ['--app-name', appName] : [];
Expand Down