fix(vue): lifecycles now fire on tabs pages - #25786
Merged
Merged
Conversation
averyrousseau
approved these changes
Aug 22, 2022
sean-perkins
approved these changes
Aug 23, 2022
7 tasks
This was referenced Sep 1, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #25784
When navigating to an inner tabs page (Tab1), the
currentMatchedRouteRefis the route definition for the Tab1 page andpreviousMatchedRouteRefisundefined. We then setpreviousMatchedRouteReftocurrentMatchedRouteRefso that we can have a reference to the last route that this outlet matched next time thecurrentMatchedRouteRefchanges.When navigating away from the tabs context,
currentMatchedRouteRefbecomesundefinedbutpreviousMatchedRouteRefstays at Tab1. SincecurrentMatchedRouteRefis undefined, we return early and do not updatepreviousMatchedRouteRef. This means that when we navigate back to Tabs1, bothcurrentMatchedRouteRefandpreviousMatchedRouteRefmatch Tab1. As a result, we do not callsetupViewItemand the inner Tab1 page does not fire lifecycle hooks.What is the new behavior?
previousMatchedRouteRefwhen navigating away from a page.Does this introduce a breaking change?
Other information