Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/src/components/breadcrumb/breadcrumb.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,12 @@ export class Breadcrumb implements ComponentInterface {
</button>
)}
{showSeparator && (
<span class="breadcrumb-separator" part="separator">
/**
* Separators should not be announced by narrators.
* We add aria-hidden on the span so that this applies
* to any custom separators too.
*/
<span class="breadcrumb-separator" part="separator" aria-hidden="true">
<slot name="separator">
{mode === 'ios' ? (
<ion-icon icon={chevronForwardOutline} lazy={false} flip-rtl></ion-icon>
Expand Down
17 changes: 17 additions & 0 deletions core/src/components/breadcrumbs/test/breadcrumbs.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,20 @@ it('should correctly provide the collapsed breadcrumbs in the event payload', as
expect(collapsedBreadcrumbs[1]).toBe(breadcrumb[2]);
expect(collapsedBreadcrumbs[2]).toBe(breadcrumb[3]);
});

it('should exclude the separator from narrators', async () => {
const page = await newSpecPage({
components: [Breadcrumbs, Breadcrumb],
html: `
<ion-breadcrumbs>
<ion-breadcrumb>First</ion-breadcrumb>
<ion-breadcrumb>Second</ion-breadcrumb>
</ion-breadcrumbs>
`,
});

const firstBreadcrumb = page.body.querySelector('ion-breadcrumb:first-of-type');
const separator = firstBreadcrumb.shadowRoot.querySelector('[part="separator"]');

expect(separator.getAttribute('aria-hidden')).toBe('true');
});