Skip to content

fix(react): duplicate page transitions do not happen on react 18 #25798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liamdebeasi merged 4 commits into from
Aug 23, 2022
Merged

fix(react): duplicate page transitions do not happen on react 18 #25798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85a4048
fix(react): duplicate page transitions do not happen on react 18
liamdebeasi Aug 22, 2022
0458734
chore(): use ready flag for outlet manager
liamdebeasi Aug 23, 2022
fab7aed
Merge branch 'main' into FW-2081
liamdebeasi Aug 23, 2022
ba75e85
Merge branch 'main' into FW-2081
liamdebeasi Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/react-router/src/ReactRouter/StackManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,18 @@ export class StackManager extends React.PureComponent<StackManagerProps, StackMa
registerIonPage(page: HTMLElement, routeInfo: RouteInfo) {
Comment thread
sean-perkins marked this conversation as resolved.
const foundView = this.context.findViewItemByRouteInfo(routeInfo, this.id);
if (foundView) {
const oldPageElement = foundView.ionPageElement;
foundView.ionPageElement = page;
foundView.ionRoute = true;

/**
* React 18 will unmount and remount IonPage
* elements in development mode when using createRoot.
* This can cause duplicate page transitions to occur.
*/
if (oldPageElement === page) {
return;
}
}
this.handlePageTransition(routeInfo);
}
Expand Down
16 changes: 13 additions & 3 deletions packages/react/src/routing/OutletPageManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,26 @@ export class OutletPageManager extends React.Component<OutletPageManagerProps> {
ionLifeCycleContext!: React.ContextType<typeof IonLifeCycleContext>;
context!: React.ContextType<typeof StackContext>;
ionRouterOutlet: HTMLIonRouterOutletElement | undefined;
outletIsReady: boolean;

constructor(props: OutletPageManagerProps) {
super(props);

this.outletIsReady = false;
}

componentDidMount() {
if (this.ionRouterOutlet) {
componentOnReady(this.ionRouterOutlet, () => {
this.context.registerIonPage(this.ionRouterOutlet!, this.props.routeInfo!);
});
/**
* This avoids multiple raf calls
* when React unmounts + remounts components.
*/
if (!this.outletIsReady) {
componentOnReady(this.ionRouterOutlet, () => {
this.outletIsReady = true;
this.context.registerIonPage(this.ionRouterOutlet!, this.props.routeInfo!);
});
}

this.ionRouterOutlet.addEventListener(
'ionViewWillEnter',
Expand Down