Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
Accelerator
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Type
/
to search
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
Uh oh!
There was an error while loading.
Please reload this page
.
ionic-team
/
ionic-framework
Public
Notifications
You must be signed in to change notification settings
Fork
13.3k
Star
52.6k
Code
Issues
593
Pull requests
38
Discussions
Actions
Projects
Wiki
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security and quality
Insights
fix(modal): role attribute can be customized
- #25804
#25804
Merged
liamdebeasi
merged 5 commits into
main
ionic-team/ionic-framework:main
from
FW-1973
ionic-team/ionic-framework:FW-1973
Copy head branch name to clipboard
Aug 23, 2022
Conversation
Commits
5
(5)
Checks
Files changed
Merged
fix(modal): role attribute can be customized
#25804
liamdebeasi
merged 5 commits into
main
ionic-team/ionic-framework:main
from
FW-1973
ionic-team/ionic-framework:FW-1973
Copy head branch name to clipboard
Commits
Commits on Aug 23, 2022
fix(modal): dialog role is set on the host
liamdebeasi
committed
b3efe50
View commit details
Copy full SHA for b3efe50
Browse repository at this point
fix(modal): role can be customized
liamdebeasi
committed
9f27eca
View commit details
Copy full SHA for 9f27eca
Browse repository at this point
test(modal): add tests
liamdebeasi
committed
e615c7c
View commit details
Copy full SHA for e615c7c
Browse repository at this point
Merge branch 'main' into FW-1973
averyrousseau
authored
0c2742e
View commit details
Copy full SHA for 0c2742e
Browse repository at this point
Merge branch 'main' into FW-1973
liamdebeasi
authored
11f8581
View commit details
Copy full SHA for 11f8581
Browse repository at this point
You can’t perform that action at this time.
