Skip to content

fix(angular): router outlet has mode property - #25816

Merged
liamdebeasi merged 1 commit into
mainfrom
FW-2124
Aug 24, 2022
Merged

fix(angular): router outlet has mode property#25816
liamdebeasi merged 1 commit into
mainfrom
FW-2124

Conversation

@liamdebeasi

@liamdebeasi liamdebeasi commented Aug 24, 2022

Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25813

What is the new behavior?

  • Adds the mode property to the list of inputs for the ion-router-outlet Angular component.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions Bot added the package: angular @ionic/angular package label Aug 24, 2022
@mburger81

Copy link
Copy Markdown
Contributor

Damn this was fast 🥇 👍

@liamdebeasi
liamdebeasi marked this pull request as ready for review August 24, 2022 14:24
@liamdebeasi
liamdebeasi requested a review from a team August 24, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: angular, mode property not available on ion-router-outlet

3 participants