Skip to content

fix(input): clear button is not activated on swipe - #25825

Merged
liamdebeasi merged 8 commits into
mainfrom
FW-896
Aug 29, 2022
Merged

fix(input): clear button is not activated on swipe#25825
liamdebeasi merged 8 commits into
mainfrom
FW-896

Conversation

@liamdebeasi

Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #24857

What is the new behavior?

  • Swiping the button no longer accidentally clears the input
  • The solution also fixes another bug I found during development where pressing "Space" would not activate the button. By default, buttons on the web can be activated with "Space" and "Enter".

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions Bot added the package: core @ionic/core package label Aug 25, 2022
@liamdebeasi
liamdebeasi marked this pull request as ready for review August 25, 2022 16:50
@liamdebeasi
liamdebeasi requested a review from a team August 25, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: input clear button is activated on swipe

2 participants