fix(datetime): passing min/max no longer errors on missing date information - #25836
Merged
Conversation
liamdebeasi
force-pushed
the
datetime-bound-full
branch
from
August 26, 2022 18:03
b48850f to
bcdbbfb
Compare
liamdebeasi
marked this pull request as ready for review
August 26, 2022 18:43
7 tasks
averyrousseau
approved these changes
Aug 29, 2022
sean-perkins
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: N/A
When fixing #25833, the author reported another bug where they would get
RangeError: Invalid time value at getDayColumnDatawhen settingmax="2012".The problem is that when we clamp the date to use inside of
ion-datetime, we simply return the user provided min/max datetime parts:ionic-framework/core/src/components/datetime/utils/parse.ts
Line 120 in 2cba460
This means that if developers pass
min="2012", then theminPartsobject will have no information for month, day, hour, or minute.What is the new behavior?
min="2012-10"you would get a min parts object for October 1, 2012 at 00:00.max="2022-05, you would get a max parts object for May 31, 2022 at 23:59.Does this introduce a breaking change?
Other information