fix(ios): scroll assist sizes input correctly - #27253
Merged
Merged
Conversation
|
|
sean-perkins
approved these changes
Apr 20, 2023
sean-perkins
left a comment
sean-perkins
left a comment
Contributor
There was a problem hiding this comment.
Nice work! I was just looking at this one in Discord last night.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 20, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #27249
What is the current behavior?
The cloned input/textarea for scroll assist is not sized correctly. For legacy inputs, this causes the clone to be off by ~1px because it does not have the correct height. For modern inputs, this causes the same bug as the legacy inputs plus cloned inputs overlap any floating/stacked labels. This was not a concern for legacy inputs because those inputs did not contain the label element where modern inputs do.
What is the new behavior?
bottom: 0for cloned inputs so they have the correct heightposition: relativeon the.native-wrapperso the cloned input does not flow outside of the parent container.Before
RPReplay_Final1681998081.MP4
RPReplay_Final1681998149.MP4
(Note: The legacy input bug is subtle -- the input only shifts by ~1px)
After
modernafter.mp4
legacyafter.mp4
Does this introduce a breaking change?
Other information