Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
e1dab46
fix(overlay): remove aria-hidden attribute
joselrio Jul 16, 2025
c2b40d8
fix(piker): remove aria-hidden attribute
joselrio Jul 16, 2025
bc97a8a
fix(overlay): remove unneeded tests
joselrio Jul 16, 2025
5ea744f
fix(picker-colum): run lint
joselrio Jul 16, 2025
77f60f2
fix(picker): rollback aria-hidden to avoid a11y structure issues
joselrio Jul 16, 2025
f2e4065
fix(datetime): disabled focus trap to prevent issues with focus manag…
joselrio Jul 16, 2025
7c424d7
fix(picker): run lint
joselrio Jul 16, 2025
ddc90e2
fix(picker-column): adapt structure to prevent double tab tap on keyb…
joselrio Jul 17, 2025
9b8e12d
fix(picker-column-option): changed structure in order to remove tabin…
joselrio Jul 17, 2025
e64332b
fix(picker): run lint
joselrio Jul 17, 2025
2f23ff0
fix(picker): manage focus to prevent a11y issues.
joselrio Jul 17, 2025
bd0890f
fix(picker-column-option): fixing tests
joselrio Jul 17, 2025
51936b3
fix(picker-column): fixing tests
joselrio Jul 17, 2025
079a134
fix(picker): update visual testing screenshots
joselrio Jul 18, 2025
3b19548
fix(picker-column-option): updated tests screenshots
joselrio Jul 21, 2025
13837ff
fix (picker): fixing pickers tests
joselrio Jul 21, 2025
98c1fa1
fix(picker): skipping color contrast a11y violations
joselrio Jul 21, 2025
12b60de
fix(pickers): run lint
joselrio Jul 21, 2025
4074817
chore(): add updated snapshots
Ionitron Jul 21, 2025
1261c64
Merge branch 'main' into ROU-11368-to-main
brandyscarney Aug 12, 2025
da69028
Merge branch 'main' into ROU-11368-to-main
joselrio Aug 18, 2025
e79c35a
(a11y) try to disable all content inside viewContainer
joselrio Aug 19, 2025
22a0d3a
Merge branch 'main' into ROU-11368-to-main
joselrio Aug 19, 2025
7b8097b
(a11y): back with removed code to run some tests
joselrio Aug 20, 2025
be2024b
(a11y): blur active element before setting aria-hidden
joselrio Aug 20, 2025
8240d60
(chore): Add script to create testing local packages
joselrio Aug 21, 2025
d3c691c
Merge branch 'main' into ROU-11368-to-main
joselrio Aug 21, 2025
2f1090e
(overlay): remove console.log
joselrio Aug 21, 2025
9f0a5b9
(menu): blur active element to prevent a11y reported issue
joselrio Aug 21, 2025
f12d562
Merge branch 'main' into ROU-11368-to-main
joselrio Aug 21, 2025
3c052d9
(overlay): grant previousElement is kept saved before setting the blu…
joselrio Aug 26, 2025
a4a8b81
(overlay): run lint
joselrio Aug 26, 2025
58c451e
Merge branch 'main' into ROU-11368-to-main
joselrio Aug 26, 2025
42898e6
(overlay): change validation to focus previous element
joselrio Aug 27, 2025
b7f9d37
(overlay): fixing validation
joselrio Aug 27, 2025
7c20ca4
(overlay): fixing issues by readapting logic
joselrio Aug 27, 2025
edb99f5
(overlay): run lint
joselrio Aug 27, 2025
157a113
(packages): update local sync and pack
joselrio Aug 27, 2025
3dec35c
(overlay): clear unneeded code and fix focus behaviour moment
joselrio Aug 27, 2025
3598b91
(overlay): remove ion-nav for being hidden for a11y
joselrio Aug 28, 2025
b6712f4
(nav): blur active element before page transitions
joselrio Aug 28, 2025
5ccaea9
(nav): run lint
joselrio Aug 28, 2025
a103a79
(nav): revert changes made
joselrio Aug 28, 2025
c679fd9
Update core/src/components/picker-column-option/test/a11y/picker-colu…
joselrio Sep 3, 2025
170f114
Update core/src/components/picker/test/a11y/picker.e2e.ts
joselrio Sep 3, 2025
c444ba2
Update core/src/components/picker-column-option/test/a11y/picker-colu…
joselrio Sep 3, 2025
6ea9eec
Update core/src/components/picker/test/a11y/picker.e2e.ts
joselrio Sep 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(picker): run lint
  • Loading branch information
joselrio committed Jul 17, 2025
commit e64332b3abe97a11913cfdaca3ce3d97896b0ec1
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export class PickerColumnOption implements ComponentInterface {
['option-disabled']: disabled,
})}
>
<div class={"picker-column-option-button"} role="button" aria-label={ariaLabel} onClick={() => this.onClick()}>
<div class={'picker-column-option-button'} role="button" aria-label={ariaLabel} onClick={() => this.onClick()}>
<slot></slot>
</div>
</Host>
Expand Down
1 change: 0 additions & 1 deletion core/src/components/picker-column/picker-column.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,6 @@ export class PickerColumn implements ComponentInterface {
return el ? el.getAttribute('aria-label') ?? el.innerText : '';
};


render() {
const { color, disabled, isActive, numericInput } = this;
const mode = getIonMode(this);
Expand Down