feat(react): ship starters with react 18 - #1729
Merged
Merged
Conversation
liamdebeasi
marked this pull request as ready for review
August 25, 2022 14:27
sean-perkins
approved these changes
Sep 2, 2022
|
react-router@5.3.4 was released, where dependency warning was removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createRootAPI (https://reactjs.org/link/switch-to-createroot)Do not merge until ionic-team/ionic-framework#25798 has been released in Ionic.
Needs #1728 to be merged first for updated deps.
Note: Developers may encounter a peer dependency warning for
mini-create-react-context@0.4.1. According to the React Router developer, this can be safely ignored. However, they do not have plans to fix this asmini-create-react-contextis now read-only: remix-run/react-router#9014 (comment). This is not a bug in Ionic and will not impact production applications. React Router v6 does not use this dependency.