Skip to content

fixing the NCEI RA archive notebook - #11

Merged
ocefpaf merged 4 commits into
ioos:mainfrom
MathewBiddle:ncei_archive_update
Oct 1, 2021
Merged

fixing the NCEI RA archive notebook#11
ocefpaf merged 4 commits into
ioos:mainfrom
MathewBiddle:ncei_archive_update

Conversation

@MathewBiddle

@MathewBiddle MathewBiddle commented Sep 3, 2021

Copy link
Copy Markdown
Contributor
  • API change
  • plotting change

@MathewBiddle
fixing the notebook
2f0d505 
- API change
- plotting change
@review-notebook-app

review-notebook-app Bot commented Sep 3, 2021

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@MathewBiddle

MathewBiddle commented Sep 3, 2021

Copy link
Copy Markdown
Contributor Author

xref:

@MathewBiddle
MathewBiddle marked this pull request as ready for review September 29, 2021 14:20
@MathewBiddle MathewBiddle added the bug Something isn't working label Sep 29, 2021
@MathewBiddle

MathewBiddle commented Sep 29, 2021

Copy link
Copy Markdown
Contributor Author

@ocefpaf This should be ready to merge. Hopefully I've fixed all the problems, including the formatting.

@ocefpaf

ocefpaf commented Sep 29, 2021

Copy link
Copy Markdown
Member

I wonder where these conflicts are coming from. Conflicts with notebooks are really hard to manage. I usually just rebase and overwrite with my own version or close the PR and open a new one.

@MathewBiddle
Merge branch 'main' into ncei_archive_update
8107263 
# Conflicts:
#	jupyterbook/content/code_gallery/data_access_notebooks/2017-06-12-NCEI_RA_archive_history.ipynb
@MathewBiddle

MathewBiddle commented Sep 30, 2021

Copy link
Copy Markdown
Contributor Author

Think I fixed the conflicts.

@MathewBiddle

MathewBiddle commented Sep 30, 2021

Copy link
Copy Markdown
Contributor Author

Turns out I had the old Code Gallery directory and didn't update the branch to the most recent organization. Everything should be okay now. LMK if anything goes haywire.

@MathewBiddle MathewBiddle mentioned this pull request Sep 30, 2021
Closed
@ocefpaf
ocefpaf merged commit 84d6651 into ioos:main Oct 1, 2021
@MathewBiddle

MathewBiddle commented Oct 8, 2021

Copy link
Copy Markdown
Contributor Author

@ocefpaf, I'm confused here. Looks like this PR was merged and the notebook updated. However, it looks like something isn't right with the GHA as the branch gh-pages hasn't been updated since Sept. 2nd.

Is there something that needs to be followed up on?

@ocefpaf

ocefpaf commented Oct 8, 2021

Copy link
Copy Markdown
Member

Checking it...

@MathewBiddle

MathewBiddle commented Oct 8, 2021

Copy link
Copy Markdown
Contributor Author

I think tests was failing somewhere: https://github.com/ioos/ioos_code_lab/actions/workflows/tests.yml

@ocefpaf

ocefpaf commented Oct 8, 2021

Copy link
Copy Markdown
Member

The notebook test should not influence the page publication. That is the main reason why we don't re-run the notebooks to publish them. Our notebooks rely on services that may fail when the CI is running and/or datasets that moved.

I think I nailed it in #31. There was still one reference to master that should be main.

@MathewBiddle
MathewBiddle deleted the ncei_archive_update branch August 31, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocefpaf ocefpaf Awaiting requested review from ocefpaf

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MathewBiddle @ocefpaf