Skip to content

Improved Max Approximator - #55

Merged
zfergus merged 21 commits into
mainfrom
improved-max-op
Sep 25, 2023
Merged

Improved Max Approximator#55
zfergus merged 21 commits into
mainfrom
improved-max-op

Conversation

@zfergus

@zfergus zfergus commented Sep 14, 2023

Copy link
Copy Markdown
Member

Description

  • Improve the max approximator used (i.e., sum over constraints) as described here.
  • Add a dtype to EE collisions to keep track of the distance type for mollified constraints
  • Initialize mesh adjacencies by default
  • Use edge length as the area weighting for codimensional edges

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Added unit test comparing convergent and not

Test Configuration:

  • OS and version: macOS 13.5.2
  • Compile and version: Apple clang version 14.0.3

Checklist:

  • I have followed the project style guide
  • My code follows the clang-format style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@zfergus zfergus changed the title Improved Max Operator Improved Max Approximator Sep 18, 2023
@zfergus
zfergus marked this pull request as ready for review September 18, 2023 13:50
@zfergus
zfergus marked this pull request as draft September 18, 2023 14:54
@zfergus
zfergus marked this pull request as ready for review September 18, 2023 16:20
@zfergus
zfergus marked this pull request as draft September 18, 2023 16:20
@zfergus
zfergus marked this pull request as ready for review September 19, 2023 02:29
@zfergus
zfergus marked this pull request as draft September 19, 2023 02:29
@zfergus
zfergus marked this pull request as ready for review September 22, 2023 03:34
Comment thread tests/test_ipc.cpp Outdated
Comment thread src/ipc/collisions/collision_constraints_builder.cpp Outdated
@zfergus
zfergus merged commit 9690566 into main Sep 25, 2023
@zfergus
zfergus deleted the improved-max-op branch September 25, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant