Skip to content

Add Support for Codim. Edge-Point Collision in 3D - #79

Merged
zfergus merged 5 commits into
mainfrom
codim-edge
Dec 11, 2023
Merged

Add Support for Codim. Edge-Point Collision in 3D#79
zfergus merged 5 commits into
mainfrom
codim-edge

Conversation

@zfergus

@zfergus zfergus commented Dec 11, 2023

Copy link
Copy Markdown
Member

Description

Add support for collision between codimensional edges and points in 3D.

Implements missing features discussed in #63.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit test

Checklist:

  • I have followed the project style guide
  • My code follows the clang-format style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@zfergus zfergus added the enhancement New feature or request label Dec 11, 2023
@codecov

codecov Bot commented Dec 11, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (968331e) 95.79% compared to head (59c4252) 95.83%.

Files Patch % Lines
src/ipc/candidates/candidates.cpp 94.44% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   95.79%   95.83%   +0.04%     
==========================================
  Files          88       88              
  Lines        7439     7518      +79     
==========================================
+ Hits         7126     7205      +79     
  Misses        313      313              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zfergus
zfergus marked this pull request as ready for review December 11, 2023 21:14
@zfergus
zfergus merged commit 52028df into main Dec 11, 2023
@zfergus
zfergus deleted the codim-edge branch December 11, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant