Conversation
Signed-off-by: Vladimir Erdman <erdman.vovaa@gmail.com>
lidel
requested changes
Nov 23, 2025
Member
There was a problem hiding this comment.
@vlerdman thank you for submitting this – any chance you could also:
- open a PR in https://github.com/ipfs/kubo that uses this in
ipfs pin addcommand and has green CI there as well
? (it would speed up review process)
Contributor
Author
@lidel Thanks for such fast feedback! Opened a PR - ipfs/kubo#11074 |
Contributor
|
Triage:
|
gammazero
approved these changes
Dec 2, 2025
gammazero
added a commit
to vlerdman/kubo
that referenced
this pull request
Dec 2, 2025
gammazero
pushed a commit
to ipfs/kubo
that referenced
this pull request
Dec 3, 2025
* Add bytes progress tracker for ipfs pin add * upgrade to boxo that has ipfs/boxo#1071
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tracking total size of nodes during graph walk. New code saves backward compability with ipfs/kubo.
Changes
merkledag.ProgressTrackerto save and updateTotalSizeof visited nodesGetLinksDirectfunction instead ofvisittestProgressIndicatorfor checkingTotalSizeReferences
pin addprogress reports. kubo#8915