Skip to content
This repository was archived by the owner on Feb 1, 2023. It is now read-only.

fix some naming nits and broadcast on search#139

Merged
Stebalien merged 3 commits intomasterfrom
fix/nits
Jun 12, 2019
Merged

fix some naming nits and broadcast on search#139
Stebalien merged 3 commits intomasterfrom
fix/nits

Conversation

@Stebalien
Copy link
Copy Markdown
Member

No description provided.

…ed peers

This fixes the case where:

1. I start downloading something.
2. A friend jumps on our WiFi.
3. Our IPFS daemons connect via local discovery.
4. I never notice that they have the file I'm looking for because I'm already downloading it from a peer.
5. The peer I'm downloading from is _really_ slow.
func (s *Session) handleRebroadcast(ctx context.Context) {

if len(s.liveWants) == 0 {
func (s *Session) handlePeriodicSearch(ctx context.Context) {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is now a rebroadcast, but, IMO, periodic search is still more accurate.

@Stebalien Stebalien requested a review from hannahhoward June 12, 2019 00:21
@Stebalien Stebalien merged commit 6d1e10d into master Jun 12, 2019
@Stebalien Stebalien deleted the fix/nits branch June 12, 2019 23:24
Stebalien added a commit that referenced this pull request Jul 4, 2019
fix some naming nits and broadcast on search
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants