This repository was archived by the owner on Feb 1, 2023. It is now read-only.
Conversation
Member
Author
|
@dirkmc I think this change is fine but please double-check. I noticed quite a bit of lock contention in 0.4.22 (ipfs/kubo#6564 (comment)). This may have already been fixed by fixing the interest stuff but I figured we could improve it a bit. |
dirkmc
approved these changes
Aug 27, 2019
Contributor
dirkmc
left a comment
dirkmc
left a comment
There was a problem hiding this comment.
This looks like it will help to me 👍
We're not using these synchronously so we can buffer them a bit to avoid blocking quite as much. This also combines all incoming channels into a single one to ensure all operations are processed in-order. This might be overkill bit it makes reasoning about this a bit simpler.
Stebalien
force-pushed
the
fix/optimize
branch
from
3b71b24 to
8454ba0
Compare
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
reduce session contention This commit was moved from ipfs/go-bitswap@565aa56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(and fix a small leak)
synchronously. Note: we could use the interface patter used elsewhere in this
library but I'm a bit worried about allocations.