implement DiskUsage for the rest of the datastores#86
Merged
Conversation
hsanjuan
approved these changes
Mar 15, 2018
Contributor
|
hmm tests failing.. |
Member
Author
we were using the wrong path for a package (path wasn't listed in the package's package.json) I have no idea why this hasn't been failing for years. Maybe the test cache expired? |
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 61.51% 51.57% -9.95%
==========================================
Files 8 16 +8
Lines 408 952 +544
==========================================
+ Hits 251 491 +240
- Misses 141 429 +288
- Partials 16 32 +16
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.