prevent closing concurrently with other operations.#42
Merged
Conversation
willscott
force-pushed
the
bug/race-close
branch
from
f662088 to
e3515b3
Compare
aschmahmann
requested changes
Feb 21, 2020
Contributor
aschmahmann
left a comment
aschmahmann
left a comment
There was a problem hiding this comment.
Thanks for looking into this. Left a couple comments to look into.
aschmahmann
approved these changes
Feb 21, 2020
Stebalien
requested changes
Feb 24, 2020
Stebalien
approved these changes
Feb 25, 2020
Member
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
LGTM with one thing to check. Merge when you've either locked on i.Release() or have confirmed that this isn't an issue (and left a comment in the code?).
willscott
force-pushed
the
bug/race-close
branch
from
b383d99 to
dbebcfb
Compare
Stebalien
approved these changes
Feb 25, 2020
Add a `sync.RWMutex` protecting the Close operation. Follows the same pattern as in go-ds-badger. Address #29 / ipfs/kubo#6880
willscott
force-pushed
the
bug/race-close
branch
from
dbebcfb to
5d92b4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
sync.RWMutexprotecting the Close operation.Follows the same pattern as in go-ds-badger.
Address #29 / ipfs/kubo#6880