feat: add telemetry#30
Conversation
fixes #28
|
ping @djmcquillan @whizzzkid |
| const telemetry = new BrowserMetricsProvider({ appKey: 'b09437fd68bb257fef9b844a624fac0859b6224e' }) | ||
| window.telemetry = telemetry |
There was a problem hiding this comment.
just wondering if this should be hook up automatically when BrowserMetricsProvider is init.
There was a problem hiding this comment.
since these are only temporary (removed when #29 is done) I don't think so, but I'm open
|
@aschmahmann any comments before i merge this? How do we deploy this once merged? |
aschmahmann
left a comment
aschmahmann
left a comment
There was a problem hiding this comment.
@SgtPooki not much to add here. Given the nature of the PR someone on your team is probably much better equipped to review than me.
The website itself should be auto-deployed by Fleek when you merge to master (it's managed by a PL account). I think it currently just deploys the "web" folder and doesn't need to do anything special, if that's changed as a function of this PR then you might need to change the Fleek configuration as well.
Also use minified telemetry.min.js instead of unminified telemetry.js. This resolves the need for a build step since ipfs-gui doesn't have access to the deployment environment.
|
lgtm with added telemetry.min.js |
4 participants
fixes #28