Return proper error when searching for block

[travisperson]

https://github.com/jbenet/go-ipfs/blob/master/server/http/http.go#L40

If the path fails to resolve a 404 should be returned if the err is a ErrNotFound, otherwise a 500 should be returned for generic server errors.

More specific when a Cast of a b58 fails it should return a 400 letting the client know that the request is a malformed syntax and should not be tried again.

A 408 should be returned if there is a timeout when resolving the path.

[whyrusleeping]

👍

[whyrusleeping]

This also brings up another bug ive noticed, that the routing system will almost never return ErrNotFound, it always seems to time out, even when only connected to a single peer.

[jbenet]

If the path fails to resolve a 404 should be returned if the err is a ErrNotFound, otherwise a 500 should be returned for generic server errors.

Agreed.

More specific when a Cast of a b58 fails it should return a 400 letting the client know that the request is a malformed syntax and should not be tried again.

Agreed

A 408 should be returned if there is a timeout when resolving the path.

408 is not very common, but yeah i guess it makes sense too.

[mappum]

Resolved in 0508de1