Skip to content

feat(pinning): allow for overwriting local pin name#10280

Merged
hacdias merged 1 commit intomasterfrom
pin-add-overwrite-name
Jan 9, 2024
Merged

feat(pinning): allow for overwriting local pin name#10280
hacdias merged 1 commit intomasterfrom
pin-add-overwrite-name

Conversation

@hacdias
Copy link
Copy Markdown
Member

@hacdias hacdias commented Jan 8, 2024

Closes #10277. Requires ipfs/boxo#537.

@hacdias hacdias added the skip/changelog This change does NOT require a changelog entry label Jan 8, 2024
@hacdias hacdias requested a review from lidel January 8, 2024 10:44
@hacdias hacdias requested a review from a team as a code owner January 8, 2024 10:44
@hacdias hacdias self-assigned this Jan 8, 2024
@hacdias hacdias force-pushed the pin-add-overwrite-name branch 2 times, most recently from 8136a05 to d9663a5 Compare January 8, 2024 11:19
@lidel lidel changed the title feat(pinning): allow for overwriting pin name feat(pinning): allow for overwriting local pin name Jan 8, 2024
Copy link
Copy Markdown
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, lgtm, thanks!

(this should be good enough for 0.26. if you want, feel free to squeeze #10281 if it does not take much time, but also fine to leave it for future)

@hacdias hacdias force-pushed the pin-add-overwrite-name branch from d9663a5 to 9d4758c Compare January 9, 2024 08:59
@hacdias hacdias merged commit 8a42186 into master Jan 9, 2024
@hacdias hacdias deleted the pin-add-overwrite-name branch January 9, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip/changelog This change does NOT require a changelog entry

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

pins: allow 'ipfs pin add --name' to override name

2 participants