fix: divide by zero fatal crash for reprovide rate check#10411
Merged
hacdias merged 2 commits intoipfs:masterfrom May 6, 2024
Merged
fix: divide by zero fatal crash for reprovide rate check#10411hacdias merged 2 commits intoipfs:masterfrom
hacdias merged 2 commits intoipfs:masterfrom
Conversation
Contributor
Author
|
@hacdias would be super happy if you or someone on your team could take a look at this soon, thanks! |
hacdias
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was running kubo on my instance, I was encountering somewhat frequent crashes of the process with the following stack trace:
I followed the stack trace to find the area where divide by 0 occurs. The solution seemed simple enough, so I went ahead and opened this PR with a simple change. I'm guessing that having a
0count for reprovide is pretty bad, but will deal with that separately.BTW I am not a go dev. My apologies if my solution seems too simplistic or a better way exists.
BTW it wasnt clear to me how/where I should update the changelog for this minor change. Please lmk. Thanks!