Skip to content

Add support for StreamArgs#1097

Merged
whyrusleeping merged 3 commits intoipfs:feat/pipefrom
travisperson:feat/stream_arg
Apr 18, 2015
Merged

Add support for StreamArgs#1097
whyrusleeping merged 3 commits intoipfs:feat/pipefrom
travisperson:feat/stream_arg

Conversation

@travisperson
Copy link
Copy Markdown
Member

New argument type StreamArgs which will create a file object from stdin.

New argument type StreamArgs which will create a file object from stdin
@jbenet jbenet added ready and removed ready labels Apr 18, 2015
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe comment what StreamArg is used for? Im not sure myself atm.

(i know the entire lib isnt well commented yet... perhaps we should lint the entire codebase)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep totally! (btw this is being merged in to feat/pipe not master if you didn't see that, just wanted a easy way to get this to @whyrusleeping).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is being merged in to feat/pipe not master if you didn't see that

ah, missed that. 👍

@whyrusleeping
Copy link
Copy Markdown
Member

@jbenet a stream arg will be used when we want to be able to pipe data through our commands. Right now the way we do it is by calling stdin one of our input files. Having inputs labeled as streams gives us a little more freedom in how to work with them.

The main use-case for this right now is the ipfs pipe command i'm working on

@whyrusleeping whyrusleeping merged commit b9c2fea into ipfs:feat/pipe Apr 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants