Conversation
guillaumemichel
force-pushed
the
reprovide-alert
branch
from
8142542 to
c8ee0d5
Compare
- add extractSweepingProvider() helper to reduce nested type switching - extract lowWorkerThreshold constant for worker availability check - fix --lan error handling to work with buffered providers
- prevent panic when both columns are empty - fix column alignment with UTF-8 characters - only track col0MaxWidth for first column (as intended)
- test basic functionality, flags, JSON output - test legacy provider behavior - test integration with content scheduling - test disabled provider configurations - add parseSweepStats helper with t.Helper()
- update tagline to "Control and monitor content providing" - simplify help descriptions - make error messages more consistent - update tests to match new error messages
``` Next reprovide at: Next prefix: ``` updated to: ``` Next region prefix: Next region reprovide: ```
Enhance documentation for the Provide system to better explain how provider records work and the differences between sweep and legacy modes. Changes to docs/config.md: - Provide section: add clear explanation of provider records and their role - Provide.DHT: add provider record lifecycle and two provider systems overview - Provide.DHT.Interval: explain relationship to expiration, contrast sweep vs legacy behavior - Provide.DHT.SweepEnabled: rewrite to explain legacy problem, sweep solution, and efficiency gains - Monitoring section: prioritize command-line tools (ipfs provide stat) before Prometheus Changes to core/commands/provide.go: - ipfs provide stat help: add explanation of provider records, TTL expiration, and how sweep batching works Changes to docs/changelogs/v0.39.md: - Add context about why stats matter for monitoring provider health - Emphasize real-time monitoring workflow with watch command - Explain what users can observe (rates, queues, worker availability)
Merged latest changes from origin/master while preserving go-libp2p-kad-dht v0.35.2-0.20251009080632-2c5b3769ca70 from this branch.
lidel
approved these changes
Oct 17, 2025
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
lgtm, just fix the indentation (probably prefer spaces as they render the same for everyone)
resolved conflicts: - go.mod/go.sum: prefer versions from master (PR #11019 merged first) - docs/config.md: prefer clearer wording from master - docs/changelogs/v0.39.md: keep reprovide-alert warning feature updates from make mod_tidy: - go-log/v2: v2.8.1 -> v2.8.2 - go-dsqueue: v0.0.5 -> v0.1.0
- extract reprovideAlertPollInterval and consecutiveAlertsThreshold constants - add extractSweepingProvider helper matching provide.go style - add defer ticker.Stop() for proper cleanup - improve variable grouping and documentation
Member
|
Resolved conflicts + small cleanup in 3433609, lgtm, merging. |
This was referenced Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #11019 (because we need to access
prov.Stats().Regular polls, checking the reprovide queue size, and printing a warning if the queue keeps increasing over a few intervals (>30min) and all workers are busy.
Warning
#11019 must be merged first.