docs: clarify LevelDB compaction limitations and StorageMax scope#11188
Merged
docs: clarify LevelDB compaction limitations and StorageMax scope#11188
Conversation
set expectations for behaviors like #11096
3 tasks
guillaumemichel
approved these changes
Feb 10, 2026
hsanjuan
reviewed
Feb 10, 2026
Comment on lines
+49
to
+53
| > [!NOTE] | ||
| > LevelDB uses a log-structured merge-tree (LSM) storage engine. When keys are | ||
| > deleted, the data is not removed immediately. Instead, a tombstone marker is | ||
| > written, and the actual data is removed later by background compaction. | ||
| > |
Contributor
There was a problem hiding this comment.
PebbleDB is the same, so needs a similar comment?
Contributor
There was a problem hiding this comment.
It does mention pebble below:
Unlike flatfs (which deletes files immediately) or pebble (which has
tombstone-aware compaction)
So, pebble works similarly but is tombstone aware, unlike levelDB.
gammazero
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is docs update to set expectations for
StorageMaxand "slow compaction on delete" for non-block behaviors likeAlso closes
opportunistic issue triage: