Skip to content

Ipns Consistency#296

Merged
jbenet merged 10 commits intomasterfrom
consistency
Nov 16, 2014
Merged

Ipns Consistency#296
jbenet merged 10 commits intomasterfrom
consistency

Conversation

@whyrusleeping
Copy link
Copy Markdown
Member

This PR changes the DHT so that it stores records instead of simple values. This allows us to add a layer of security onto the DHT, and also allows us to validate values that are stored in it.

Currently, only two value types are allows to be stored in the DHT:

  • Public Keys
    • Public keys are verified by checking their hash against the key.
    • relevant code
  • Ipns Records
    • Ipns records are verified by unmarshalling them, checking their validity type, and then performing the proper validity checks from there
    • relevant code

Other types of Ipns Validity functions should be discussed, as only one is implemented. More complex checks may require a change in how the validity functions are called (maybe add new parameters, etc).

@whyrusleeping whyrusleeping added the status/in-progress In progress label Nov 12, 2014
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@jbenet
Copy link
Copy Markdown
Member

jbenet commented Nov 13, 2014

Great PR, as always. A few codebase-friendliness comments up there, but all this LGTM!

@whyrusleeping
Copy link
Copy Markdown
Member Author

@jbenet am i good to merge?

@jbenet
Copy link
Copy Markdown
Member

jbenet commented Nov 16, 2014

@whyrusleeping depends, did the commands merge change anything here? we've officially deprecated cmd/ipfs until we migrate cmd/ipfs2 -> cmd/ipfs. Seems like no, but just verifying...

@whyrusleeping
Copy link
Copy Markdown
Member Author

If you merged over the ipfs name code then no, nothing should have changed.

@jbenet
Copy link
Copy Markdown
Member

jbenet commented Nov 16, 2014

merged over the ipfs name code

??

@whyrusleeping
Copy link
Copy Markdown
Member Author

I mean, if you've ported over the code for ipfs name publish and ipfs name resolve from the original commands set, everything should work great

@btc
Copy link
Copy Markdown
Contributor

btc commented Nov 16, 2014

those have been ported

@jbenet
Copy link
Copy Markdown
Member

jbenet commented Nov 16, 2014

I'm going to rebase this on top of new master first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants