ds-help: add helper functions to convert from Cid to DsKey and the reverse#3310
Merged
whyrusleeping merged 1 commit intomasterfrom Oct 18, 2016
Merged
ds-help: add helper functions to convert from Cid to DsKey and the reverse#3310whyrusleeping merged 1 commit intomasterfrom
whyrusleeping merged 1 commit intomasterfrom
Conversation
2b09019 to
cf9e12d
Compare
Member
|
Maybe these should be in the dshelper package? |
Contributor
Author
|
I take it you mean |
Member
|
@kevina the thing is that your helper methods would be useful in nearly every place that that package is used. |
Contributor
Author
|
No problem, I'll move it. |
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org>
cf9e12d to
c4fbe34
Compare
Contributor
Author
|
@whyrusleeping, moved |
Contributor
Author
|
@whyrusleeping tests passed. Marking a RFM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the filestore (#2634) i needed to convert from Cid to DsKey and the reverse in several places so I created two helper functions to that effect.