Conversation
Stebalien
force-pushed
the
libp2p-core
branch
2 times, most recently
from
2b0a6e3 to
249fe9e
Compare
Stebalien
changed the title
closes #6391 License: MIT Signed-off-by: Raúl Kripalani <raul@protocol.ai>
Something is broken with the cache.
Stebalien
reviewed
Jun 1, 2019
| } | ||
|
|
||
| func bootstrapAdd(r repo.Repo, cfg *config.Config, peers []config.BootstrapPeer) ([]config.BootstrapPeer, error) { | ||
| func bootstrapAdd(r repo.Repo, cfg *config.Config, peers []string) ([]string, error) { |
Member
There was a problem hiding this comment.
The BootstrapPeer type no longer exists as it was an alias for IPFSAddr.
| func bootstrapRemove(r repo.Repo, cfg *config.Config, toRemove []config.BootstrapPeer) ([]config.BootstrapPeer, error) { | ||
| removed := make([]config.BootstrapPeer, 0, len(toRemove)) | ||
| keep := make([]config.BootstrapPeer, 0, len(cfg.Bootstrap)) | ||
| func bootstrapRemove(r repo.Repo, cfg *config.Config, toRemove []string) ([]string, error) { |
Member
There was a problem hiding this comment.
This now has a new feature: One can remove a peer /ip4/.../tcp/.../p2p/QmFoo with ipfs bootstrap rm /p2p/QmFoo (no transport).
| // | ||
| // Once per address specified. However, I'm not sure of | ||
| // a good backwards compat solution. Right now, I'm just | ||
| // preserving the current behavior. |
Member
There was a problem hiding this comment.
Bleh. I'd prefer to print the multiaddrs.
| found := 0 | ||
| for _, raddr := range raddrs { | ||
| if _, last := ma.SplitLast(raddr); last.Protocol().Code == ma.P_IPFS { | ||
| if _, last := ma.SplitLast(raddr); last != nil && last.Protocol().Code == ma.P_IPFS { |
Member
|
@Kubuxu could I get a review on the second commit? I've reviewed the first commit. |
Kubuxu
approved these changes
Jun 3, 2019
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
migrate to go-libp2p-core. This commit was moved from ipfs/kubo@1a32379
gammazero
pushed a commit
to ipfs/boxo
that referenced
this pull request
Sep 29, 2023
migrate to go-libp2p-core. This commit was moved from ipfs/kubo@1a32379
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates go-ipfs to go-libp2p-core.
Prerequisites -- update go.mod and remove replace directives once these PRs are merged and released: