Conversation
extracted from Lassie
rvagg
requested review from
hannahhoward,
masih and
willscott
as code owners
rvagg
added a commit
to ipld/frisbii
that referenced
this pull request
Sep 2, 2023
rvagg
added a commit
to ipld/frisbii
that referenced
this pull request
Sep 2, 2023
rvagg
added a commit
to ipld/frisbii
that referenced
this pull request
Sep 2, 2023
rvagg
added a commit
to ipld/frisbii
that referenced
this pull request
Sep 2, 2023
Member
Author
rvagg
added a commit
to ipld/frisbii
that referenced
this pull request
Sep 2, 2023
rvagg
added a commit
to ipld/frisbii
that referenced
this pull request
Sep 2, 2023
willscott
reviewed
Sep 2, 2023
rvagg
added a commit
to filecoin-project/lassie
that referenced
this pull request
Sep 4, 2023
willscott
approved these changes
Sep 4, 2023
rvagg
added a commit
to ipld/frisbii
that referenced
this pull request
Sep 4, 2023
rvagg
added a commit
to filecoin-project/lassie
that referenced
this pull request
Sep 4, 2023
rvagg
added a commit
to ipld/frisbii
that referenced
this pull request
Sep 4, 2023
rvagg
added a commit
to filecoin-project/lassie
that referenced
this pull request
Sep 4, 2023
rvagg
added a commit
to filecoin-project/lassie
that referenced
this pull request
Sep 6, 2023
rvagg
added a commit
to filecoin-project/lassie
that referenced
this pull request
Sep 8, 2023
rvagg
added a commit
to filecoin-project/lassie
that referenced
this pull request
Sep 8, 2023
parkan
pushed a commit
to parkan/sheltie
that referenced
this pull request
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from Lassie; removed the default CARv1 option from the
NewDeferredCarWriterForPathvariant, but left it on forNewDeferredCarWriterForStream. Also had to wire upClosetoFinalizeto handle the CARv2 case (and added tests to cover the CARv2 case).