Skip to content

fix: goreleaser v2 compat, trigger release-binaries with workflow_run#540

Merged
rvagg merged 1 commit intomasterfrom
rvagg/releaser
Sep 25, 2024
Merged

fix: goreleaser v2 compat, trigger release-binaries with workflow_run#540
rvagg merged 1 commit intomasterfrom
rvagg/releaser

Conversation

@rvagg
Copy link
Member

@rvagg rvagg commented Sep 25, 2024

Ref: #536

(a small amount of 🤞 going on here, we'll see, this works for lassie)

Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved so that you can try the changes here if you wish. We can revert if this doesn't fix it.


workflow_dispatch:
workflow_run:
workflows: [Releaser]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relases created by GitHub actions will not create other workflows, unless they use a GitHub Token other than the built-in default.

An alternative solution is to delete and recreate the release manually.

I pointed this out to IPDX team a while back and I believe there has been fixes rolled out to the unified CI? It's worth checking with them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 this seems to work in the lassie repo where we have essentially the same setup and no custom token configured

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice

@rvagg rvagg merged commit 0f4efe3 into master Sep 25, 2024
@rvagg rvagg deleted the rvagg/releaser branch September 25, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants