Fixed the initialization of counter in MicroTime #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ircmaxell
added a commit
that referenced
this pull request
Mar 8, 2013
Fixed the initialization of counter in MicroTime
Owner
|
Looks great to me. Thanks! |
flip111
added a commit
to flip111/RandomLib
that referenced
this pull request
Dec 7, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static $counter in RandomLib\Source\Microtime is always equal to zero at the end of __construct. I tested with a 64bit Linux environment running PHP 5.3.10.
This comes because bindec() that doesn't work fine on this environment. I replaced it using unpack(). I also provided a Unit Test to cover this behaviour.