docs: add examples/explanation of using tar.t#309
Merged
lukekarrys merged 2 commits intomainfrom Mar 13, 2022
isaacs/doc-list-clarifications
Merged
docs: add examples/explanation of using tar.t#309lukekarrys merged 2 commits intomainfrom isaacs/doc-list-clarifications
lukekarrys merged 2 commits intomainfrom
isaacs/doc-list-clarifications
Conversation
There are node versions being tested that don't work with the latest npm, so this is causing CI to fail.
wraithgar
reviewed
Feb 28, 2022
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
|
|
||
| - name: use latest npm |
Contributor
There was a problem hiding this comment.
Looks like this was removed to get windows CI passing.
This file will eventually be managed buy @npmcli/template-oss and end up being clobbered the next time that module has a new version.
The ci.yml that template-oss installs works fine w/ windows so this change is also fine to have for now.
wraithgar
approved these changes
Feb 28, 2022
lukekarrys
reviewed
Feb 28, 2022
| `tar.ReadEntry` objects. However, they don't emit `'data'` or `'end'` | ||
| events. (If you want to get actual readable entries, use the | ||
| `tar.Parse` class instead.) | ||
| If the `file` option is _not_ provided, then returns an event emitter that |
Contributor
There was a problem hiding this comment.
Suggested change
| If the `file` option is _not_ provided, then returns an event emitter that | |
| If the `file` option is _not_ provided, then it returns an event emitter that |
lukekarrys
approved these changes
Feb 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #308
Fix: #307
References