chore: use a local instead of remote file for test#337
Merged
lukekarrys merged 1 commit intomainfrom Oct 29, 2022
Merged
Conversation
767530e to
341e750
Compare
Contributor
|
nice! that's good to know. |
Contributor
Author
|
@webark I learned it while making this PR 😄 You're original PR was very helpful and I was fine to leave it as an |
Contributor
|
it's probably good to still have a test that makes sure this works with a stream sent directly from http/https. I know |
341e750 to
60c3697
Compare
Contributor
Author
|
Force pushed a new commit that adds another test mocked with |
60c3697 to
d0fedb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to replicate the same behavior from #332 by piping a readable
stream with a
highWaterMarkof 1 to extract. I confirmed this teststill failed without the fixes from #332 and now passes.