-
Notifications
You must be signed in to change notification settings - Fork 299
PyCuAmpcor: compile files as pure C++ when possible, fix Makefile #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyCuAmpcor: compile files as pure C++ when possible, fix Makefile #622
Conversation
This speeds up compilation, and brings it closer in line with the CPU port
Now working with .cpp files and pybind11 module setup.py step no longer needed
|
Thanks, @rtburns-jpl ! Looks good to me. I understand the changes will make interfacing with python easier. |
|
For sure, I like CMake much better. I wasn't sure where to put a standalone CMakeLists.txt since there is already the project's CMakeLists.txt in this directory, but I suppose we could either put a standalone one in src/, or figure out how to make the existing one work standalone as well. For now, I think I'll merge this, so that we have at least something working. |
|
@rtburns-jpl , I was able to get this setup on my end, but encounter a bug I'm not sure how to address. Could you please advise? Thanks:
|
|
"--gpuid 2" is to choose the gpu device with id=2 if you have multiple gpus. Please use "nvidia-smi" to check the available gpus on your computer. If you only have one, please use "--gpuid 0" or simply neglect this setting (since gpuid=0 is the default setting). |
|
Thanks @lijun99 , that part was an input error on my end! However after making the suggested commandline adjustment, I encounter a new error along the same part of the routine:
I have the impression that the parameters I specified in my For reference, here is my available GPU:
Could you perhaps advise on what may be the issue here, be it may on the |
|
I think you just need to add the appropriate compute version for your device here isce2/contrib/PyCuAmpcor/src/Makefile Lines 9 to 10 in 9457a34
|
cc @lijun99