alosStack: easy data preparation + ignore non-numeric folders in the data/download dir
#834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ ignore the non-numeric foldres in the data download directory, similar to stripmapStack, in the following scripts:
- StackPublic
- create_cmds
- read_data
+ create_cmds: print out the number of acquisitions and pairs
+ create_cmds: ignore empty input of `insar.bbox` arg, in addition to the existing None input, otherwise, it causes the following err
```
Traceback (most recent call last):
File "/home/yunjunz/tools/isce2/src/isce2/contrib/stack/alosStack/geocode.py", line 72, in <module>
bbox = [float(x) for x in bbox.split('/')]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/yunjunz/tools/isce2/src/isce2/contrib/stack/alosStack/geocode.py", line 72, in <listcomp>
bbox = [float(x) for x in bbox.split('/')]
^^^^^^^^
ValueError: could not convert string to float: ''
```
hfattahi
approved these changes
Apr 8, 2024
Collaborator
hfattahi
left a comment
hfattahi
left a comment
There was a problem hiding this comment.
LGTM. The original functionality seems untouched and the new functionality is turned off by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two features to facilitate the
alosStackprocessing. Default behaviors are not changed.stripmapStack/prepSlcALOS2.py: add the optional--alosStackoption to leverage this script to prepare the SLC data structure expected byalosStack. Default is turned off.alosStack: ignore the non-numeric folders in the data download directory, similar to stripmapStack, such as theARCHIVED_FILESfolder generated bystripmapStack/prepSlcALOS2above, instead of (re)moving the original downloaded zip/tar files. This includes changes in the following scripts:It also includes two minor print out msg and bug fixes:
alosStack/create_cmds: print out the number of acquisitions and pairsalosStack/create_cmds: ignore empty input ofinsar.bboxarg, in addition to the existing None input, otherwise, it causes the following error: