fpv search: add a unique name attribute to fully kill autofill#81
Open
itamarwe wants to merge 1 commit into
Open
fpv search: add a unique name attribute to fully kill autofill#81itamarwe wants to merge 1 commit into
itamarwe wants to merge 1 commit into
Conversation
autocomplete=off alone wasn't enough — with no name attribute, iOS/Chrome fall back to heuristics on the placeholder/aria-label text and still offer autofill. Adds name="site-search-query" (long and specific, per Apple's own guidance, so it isn't mistaken for a contact-form field like name="q" would be). Verified in the rendered DOM headlessly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YVLz2Gms21jzv8S6NE1XaT
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
Superseded by #83, which consolidates this PR's content plus #79 into a single PR against Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #80 (already merged), which added
autocomplete="off"to the gallery search input — that alone wasn't enough. With nonameattribute, iOS/Chrome fall back to heuristics on theplaceholder/aria-labeltext and still offered autofill.Adds
name="site-search-query"— long and specific per Apple's own guidance, so it isn't mistaken for a short field likename="q"would be, which aggressive iOS heuristics can misclassify as a contact-form field.Same as the prior patches: this edits the built bundle (
public/fpv/assets/index-ObpdO5MX.js) directly, since the viewer source lives infpv-drone-strikes-lebanon-dataset— the durable fix should land there on the next rebuild.Verified: patched file passes
node --check; servedpublic/headlessly and confirmed the rendered DOM:🤖 Generated with Claude Code
https://claude.ai/code/session_01YVLz2Gms21jzv8S6NE1XaT
Generated by Claude Code