Feature/ticket mapper - #10
Closed
simonforsberg wants to merge 6 commits into
Closed
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds ticket creation flow: a Spring MVC controller with GET/POST endpoints, a service that persists tickets and maps entities to DTOs, and a mapper component converting Ticket entities to TicketViewDTOs. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Controller as "TicketController"
participant Service as "TicketService"
participant Repo as "TicketRepository"
participant Mapper as "TicketMapper"
User->>Controller: GET /create
Controller-->>User: 200 (render create view with empty TicketCreateDTO)
User->>Controller: POST /create (form data)
Controller->>Controller: validate TicketCreateDTO
alt validation fails
Controller-->>User: 200 (render create view with errors)
else validation succeeds
Controller->>Service: createNewTicket(dto)
Service->>Repo: save(new Ticket)
Repo-->>Service: persisted Ticket
Service->>Mapper: entityToViewDTO(persisted Ticket)
Mapper-->>Service: TicketViewDTO
Service-->>Controller: TicketViewDTO
Controller-->>User: 302 Redirect to /home
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/main/java/org/example/alfs/services/TicketService.java (1)
30-32: Use a clearer variable name for the persisted entity.
Line 30usessave, which reads like an action. A name likesavedTicketimproves readability.♻️ Suggested cleanup
- Ticket save = ticketRepository.save(ticket); - - return ticketMapper.entityToViewDTO(save); + Ticket savedTicket = ticketRepository.save(ticket); + return ticketMapper.entityToViewDTO(savedTicket);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/java/org/example/alfs/services/TicketService.java` around lines 30 - 32, In TicketService, rename the local variable that holds the persisted entity from save to a clearer name like savedTicket where ticketRepository.save(ticket) is called and then passed into ticketMapper.entityToViewDTO; update both the assignment and the subsequent reference so the code reads e.g. Ticket savedTicket = ticketRepository.save(ticket); return ticketMapper.entityToViewDTO(savedTicket);src/main/java/org/example/alfs/controllers/TicketController.java (1)
19-24: Preferprivate finalfor injected dependencies.Since constructor injection is already used, making
ticketServiceimmutable improves encapsulation and prevents accidental reassignment.🔧 Suggested refactor
- TicketService ticketService; + private final TicketService ticketService;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/java/org/example/alfs/controllers/TicketController.java` around lines 19 - 24, The injected TicketService field should be made immutable and encapsulated: change the TicketController's ticketService field to "private final TicketService ticketService" and keep the existing constructor TicketController(TicketService ticketService) to assign it; update any direct field access if present to use the private field (no other constructor changes needed). Ensure the class compiles after marking the field final and that there are no reassignment sites for ticketService.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/main/java/org/example/alfs/controllers/TicketController.java`:
- Around line 31-39: The POST handler createNewTicket in TicketController is
using an unnamed `@ModelAttribute` so it binds as "ticketCreateDTO" while the GET
handler adds the form model as "ticket"; update the POST to use the same
attribute name by changing the `@ModelAttribute` to explicitly use "ticket" (or
alternatively ensure you re-add model.addAttribute("ticket", ticketCreateDTO)
before returning on validation errors) so the create view and validation errors
render against the same attribute name.
---
Nitpick comments:
In `@src/main/java/org/example/alfs/controllers/TicketController.java`:
- Around line 19-24: The injected TicketService field should be made immutable
and encapsulated: change the TicketController's ticketService field to "private
final TicketService ticketService" and keep the existing constructor
TicketController(TicketService ticketService) to assign it; update any direct
field access if present to use the private field (no other constructor changes
needed). Ensure the class compiles after marking the field final and that there
are no reassignment sites for ticketService.
In `@src/main/java/org/example/alfs/services/TicketService.java`:
- Around line 30-32: In TicketService, rename the local variable that holds the
persisted entity from save to a clearer name like savedTicket where
ticketRepository.save(ticket) is called and then passed into
ticketMapper.entityToViewDTO; update both the assignment and the subsequent
reference so the code reads e.g. Ticket savedTicket =
ticketRepository.save(ticket); return ticketMapper.entityToViewDTO(savedTicket);
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 73c3b789-959a-46d3-bd1a-335ce73ac03e
📒 Files selected for processing (3)
src/main/java/org/example/alfs/controllers/TicketController.javasrc/main/java/org/example/alfs/mapper/TicketMapper.javasrc/main/java/org/example/alfs/services/TicketService.java
…cketService` final, adjust method annotations, and improve variable naming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit